-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing test test_badopt #32
Comments
Could you clarify when you get this error? The unit tests suite currently passes without any error on my computer and in GitHub Actions. Is this error caused by PR #33? |
It's not change related - the master branch fails the same way. Could be platform related: |
OK, so it only happened in your development environment so far. Could you indicate on what repository did you get this error? Is it a public GitHub One? |
I got it during a git commit (pre-commit) because 'py.test' is effectively executing the tests. I did not get this prior to the first PR as far as I remember. This just required a small update in test case considering that NotADirectoryError is a suitable exception when trying to open "a/b". However, I now just think of the following: I often use just 1 letter for temporary files and I created a file name "a' at the root. I updated a test case to that it trys to access 'README.md/dummy'.
|
Just though of another type of error: when the file is a directory.
|
I merge from the master branch where you just integrated the changes from #33. https://github.com/mdeweerd/pre-commit-hooks/runs/6366531305?check_suite_focus=true |
While updating PRs as per request, I now have this new error during tests.
I a checking on how to fix that, just registering this as an issue to explain why the future change is there.
This breaks commit because of more stringent pre-commit target (all tests must pass).
The text was updated successfully, but these errors were encountered: