Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do no add space when --comment-style arg is empty string #29 #33

Merged
merged 7 commits into from
May 10, 2022
Merged

Do no add space when --comment-style arg is empty string #29 #33

merged 7 commits into from
May 10, 2022

Conversation

mdeweerd
Copy link
Contributor

@mdeweerd mdeweerd commented May 7, 2022 •
edited
Loading

Replaces PR #31 .

  • .gitignore coverage db in subdirs
  • Cleanup/extend .pre-commit-config.yaml:
  • Correct test target,
  • Add mypy
  • Add extra checks (shebang)
  • Make shebang files executeable
  • Add --no-space option
  • Do no add space when --comment-style arg is empty string Avoid space insertion when inserting licence #29
  • Fix test case tests/remove_crlf_test.py to allow NotADirectoryError for non existing a/b (Fix Failing test test_badopt #32).
  • Change new --no-space option to --no-space-in-comment-prefix

@mdeweerd
Add missing resources, and ignore coverage db in subdirs
92d16f7
@mdeweerd
Cleanup .pre-commit-config.yaml, correct test target, add mypy
0cd82df
@mdeweerd
Make shebang files executeable, better extra space logic.
78efb9e 
- Make shebang files executeable
- Add --no-space option
- Do no add space when --comment-style arg is empty string #29
- Fix test case tests/remove_crlf_test.py to allow NotADirectoryError for non existing a/b.
@mdeweerd
Change new --no-space option to --no-space-in-comment-prefix
c7d9cf2
This was referenced May 7, 2022
Merged
Closed
@Lucas-C Lucas-C mentioned this pull request May 9, 2022
Closed
@Lucas-C
Copy link
Owner

Lucas-C commented May 10, 2022 •
edited
Loading

Thank you for your contribution @mdeweerd!
Merging now

@Lucas-C Lucas-C merged commit 2dc5089 into Lucas-C:master May 10, 2022
@mdeweerd mdeweerd deleted the no_space_for_comment branch May 10, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lucas-C Lucas-C Lucas-C left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test test_badopt
3 participants
@mdeweerd @Lucas-C @leslinice