Support flexible years in licenses (#23) #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucas-C
requested changes
Jan 18, 2023
| # Strict and flexible years | ||
| ('module_with_stale_year_in_license.py', '#', False, None, False, False), | ||
| ('module_with_stale_year_range_in_license.py', '#', False, None, False, False), | ||
| ('module_with_license.py', '#', False, 'module_without_license.py', True, True), |
There was a problem hiding this comment.
Same suggestion here: could you add a test with a badly formatted year range please?
The new flag `--use-current-year` allows automatically updating the year in copyright headers, using always the current year when inserting new ones and removing headers regardless of the years they contain.
Thanks for the review, I like the code better now. |
Lucas-C
reviewed
Jan 22, 2023
| @@ -84,6 +85,20 @@ In case you want to remove the comment headers introduced by | |||
| 3. Remove the `--remove-header` arg and update your `LICENSE.txt` ; | |||
| 4. Re-run the hook on all your files. | |||
|
|
|||
| #### Handling years flexibly | |||
|
|
|||
| You can add `--use-current-year` to change how the hook treats years in the | |||
|
Merging this now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new flag
--flexible-yearsallows automatically updating the year in copyright headers, using always the current year when inserting new ones and removing headers regardless of the years they contain.