Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a schema.sql file-Team member #3 #43

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Create a schema.sql file-Team member #3 #43

merged 1 commit into from
Jun 5, 2023

Conversation

Kaghenimbale
Copy link
Collaborator

@Kaghenimbale Kaghenimbale commented Jun 5, 2023

Create a schema.sql file with tables that will be analogical to the structure of the classes that you created:

  • Create game table
  • Create author table

Copy link
Collaborator

@codeWithHyder codeWithHyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: APPROVED 🟢

Hi Kaghenimable (https://github.com/Kaghenimbale) ✋
Your project is complete! There is nothing else to say other than... it's time to merge it: ship it:
Congratulations! 🎉 👏 👏 💯
Highlights!
• Followed Gitflow ✔️
• Good commit messages ✔️
• Linters are passing ✔️
• Descriptive Pull request ✔️
• Professional readme ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you consider them as they can improve your code.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread and tag me @codeWithHyder if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

@Kaghenimbale Kaghenimbale merged commit 27d14c4 into dev Jun 5, 2023
1 check passed
@Lucas-Erkana Lucas-Erkana moved this from In progress to To do in Ruby Group Capstone Project Jun 6, 2023
@Lucas-Erkana Lucas-Erkana linked an issue Jun 6, 2023 that may be closed by this pull request
@Lucas-Erkana Lucas-Erkana moved this from To do to Done in Ruby Group Capstone Project Jun 6, 2023
@Lucas-Erkana Lucas-Erkana moved this from Done to To do in Ruby Group Capstone Project Jun 6, 2023
@Lucas-Erkana Lucas-Erkana moved this from To do to Done in Ruby Group Capstone Project Jun 6, 2023
@Lucas-Erkana Lucas-Erkana moved this from Done to To do in Ruby Group Capstone Project Jun 6, 2023
@Lucas-Erkana Lucas-Erkana changed the title Add the game and author table Create a schema.sql file with tables-Team member #3 Jun 6, 2023
@Lucas-Erkana Lucas-Erkana linked an issue Jun 6, 2023 that may be closed by this pull request
@Lucas-Erkana Lucas-Erkana moved this from To do to Done in Ruby Group Capstone Project Jun 6, 2023
@Lucas-Erkana Lucas-Erkana changed the title Create a schema.sql file with tables-Team member #3 Create a schema.sql-Team member #3 Jun 6, 2023
@Lucas-Erkana Lucas-Erkana changed the title Create a schema.sql-Team member #3 Create a schema.sql file-Team member #3 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[1pt] Create a schema.sql file with tables-Team member #3
2 participants