Added grass-like blocks replacement when an opaque block is on top #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a block is on top.
|
Looks good to me, if the blocks were sorted by height then we could go from top to bottom and would know if the above block is opaque/transparent but this is fine as it is. |
|
Also, there shouldn't be any changes to |
|
Closes #82. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the blocks are determined in a for() loop, you can't really know if the block on top of the current one will be transparent or not while you're in the loop. So I had to add a second one after which corrects the grassy blocks that had an opaque block on top. There might be a better implementation but I couldn't find one.