Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config into a file #89

Closed
LucasPickering opened this issue Dec 21, 2023 · 0 comments · Fixed by #90
Closed

Move config into a file #89

LucasPickering opened this issue Dec 21, 2023 · 0 comments · Fixed by #90
Labels
qol Improvements that make usage smoother, without introducing new functionality

Comments

@LucasPickering
Copy link
Owner

Having configuration in the TUI is kinda clunky. It'd be better off in a file so it can be persisted and shared between sessions.

@LucasPickering LucasPickering added the qol Improvements that make usage smoother, without introducing new functionality label Dec 21, 2023
LucasPickering added a commit that referenced this issue Dec 21, 2023
Supporting live changes to the config is going to get increasingly complicated, and doesn't provide much value. The file is a necessary long-term solution anyway, for things like configurable theme and keybindings.

Closes #89
LucasPickering added a commit that referenced this issue Dec 21, 2023
Supporting live changes to the config is going to get increasingly complicated, and doesn't provide much value. The file is a necessary long-term solution anyway, for things like configurable theme and keybindings. Also deleted DrawContext since it's just one field now.

Closes #89
LucasPickering added a commit that referenced this issue Dec 21, 2023
Supporting live changes to the config is going to get increasingly complicated, and doesn't provide much value. The file is a necessary long-term solution anyway, for things like configurable theme and keybindings. Also deleted DrawContext since it's just one field now.

Closes #89
LucasPickering added a commit that referenced this issue Dec 21, 2023
Supporting live changes to the config is going to get increasingly complicated, and doesn't provide much value. The file is a necessary long-term solution anyway, for things like configurable theme and keybindings. Also deleted DrawContext since it's just one field now.

Closes #89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qol Improvements that make usage smoother, without introducing new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant