Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Node: Add Subscribers to Lists #4

Closed
anantanandgupta opened this issue Mar 25, 2024 · 4 comments
Closed

Missing Node: Add Subscribers to Lists #4

anantanandgupta opened this issue Mar 25, 2024 · 4 comments

Comments

@anantanandgupta
Copy link
Contributor

Dear @LucasSovre, as I am actively following this repo, I realized that you have a new code of conduct for the PRs, so here I am opening a feature request.

the feature in question is the capability of Listmonk to add one or more subscribers to one or more lists. There is an api endpoint available from Listmonk as documented here. This feature is missing in this module.

I will quickly work on the feature and create a PR.
@LucasSovre
Copy link
Owner

Thanks, for creating an issue, if the improvement ask is legitimate, we will work on it as soon as possible, do not hesitate to create your own pull-request 😉

@LucasSovre
Copy link
Owner

Dear @LucasSovre, as I am actively following this repo, I realized that you have a new code of conduct for the PRs, so here I am opening a feature request.

the feature in question is the capability of Listmonk to add one or more subscribers to one or more lists. There is an api endpoint available from Listmonk as documented here. This feature is missing in this module.

I will quickly work on the feature and create a PR.

Amazing, do not hesitate to tag me on the PR and I will review it as soon as possible

anantanandgupta added a commit to anantanandgupta/listmonk-n8n that referenced this issue Mar 25, 2024
@anantanandgupta
added subscriber's list management feature
b01ee45 
- with this new node you will be able to add, romove of unsubscribe a user from given list in bulk LucasSovre#4
- fixed a trivial codding issue related to n8n framework (suffix `=`).
- updated version to 1.0.6
anantanandgupta added a commit to anantanandgupta/listmonk-n8n that referenced this issue Mar 25, 2024
@anantanandgupta
added subscriber's list management feature
94f4b8d 
- with this new node you will be able to add, romove of unsubscribe a user from given list in bulk LucasSovre#4
- fixed a trivial codding issue related to n8n framework (suffix `=`).
- updated version to 1.0.6
@anantanandgupta anantanandgupta mentioned this issue Mar 25, 2024
Merged
anantanandgupta added a commit to anantanandgupta/listmonk-n8n that referenced this issue Mar 25, 2024
@anantanandgupta
added subscriber's list management feature
8350305 
- with this new node you will be able to add, romove of unsubscribe a user from given list in bulk LucasSovre#4
- fixed a trivial codding issue related to n8n framework (suffix `=`).
- updated version to 1.0.6
@anantanandgupta
Copy link
Contributor Author

@LucasSovre ... here you go :)

@LucasSovre
Copy link
Owner

merged and published to npm package with https://github.com/LucasSovre/listmonk-n8n/releases/tag/1.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anantanandgupta @LucasSovre