Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

S3 storage implementation #47

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

S3 storage implementation #47

wants to merge 16 commits into from

Conversation

NahisWayard
Copy link

No description provided.

TCC.Lib/Helpers/StringExtensions.cs Show resolved Hide resolved
TCC.Lib/Storage/IRemoteStorage.cs Outdated Show resolved Hide resolved
TCC.Lib/Storage/RemoteStorageFactory.cs Outdated Show resolved Hide resolved
TCC.Lib/Storage/RemoteStorageFactory.cs Outdated Show resolved Hide resolved
TCC.Lib/Storage/RemoteStorageFactory.cs Outdated Show resolved Hide resolved
TCC.Lib/Options/CompressOption.cs Show resolved Hide resolved
|| string.IsNullOrEmpty(option.AzBlobSaS))
{
logger.LogCritical("Configuration error for azure blob upload");
continue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question métier : on continue sur les autres types d'upload, ou un arrête complétement le programme ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pense qu'on peut laisser tel quel les implem existantes ?

TCC.Lib/Storage/RemoteStorageFactory.cs Outdated Show resolved Hide resolved
TCC.Lib/Storage/S3RemoteStorage.cs Outdated Show resolved Hide resolved
@NahisWayard NahisWayard marked this pull request as ready for review March 7, 2023 11:31
@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

1.1% 1.1% Coverage
0.0% 0.0% Duplication

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants