feat(modal): handle Observable values for modal/sidepanel labels #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeNury
added
👥 Front
GuillaumeNury
force-pushed
the
modal.observable.content
branch
from
e13fbd7
to
f1df1d5
Compare
shajz
previously approved these changes
Sep 14, 2022
| @@ -13,7 +12,7 @@ import { LU_MODAL_CONFIG, LU_MODAL_REF_FACTORY, LU_MODAL_TRANSLATIONS } from './ | |||
| import { luModalTranslations } from './modal.translate'; | |||
|
|
|||
| @NgModule({ | |||
| imports: [OverlayModule, PortalModule, CommonModule, A11yModule, LuTooltipModule], | |||
| let fixture: ComponentFixture<ModalOpenerComponent>; | ||
|
|
||
| beforeEach(async () => { | ||
| await TestBed.configureTestingModule({ |
There was a problem hiding this comment.
Hmm y a spectator sur lf normalement si tu veux moins t'embêter (cc @mathieu-bellange). Y a d'autres specs pour avoir des exemples d'utilisation
GuillaumeNury
force-pushed
the
modal.observable.content
branch
from
f1df1d5
to
137fd46
Compare
shajz
approved these changes
Sep 14, 2022
GuillaumeNury
commented
Sep 14, 2022
|
|
||
| function openModal<T>(type: Type<T>): T { | ||
| spectator.component.modal.open(type); | ||
| return spectator.debugElement.parent.query(By.directive(type)).componentInstance as T; |
There was a problem hiding this comment.
@mathieu-bellange In a perfect world, I would have done:
spectator.query(type, { root: true })But the root option only exists for string selectors.
There was a problem hiding this comment.
Waiting for a release of Spectator with this PR 😃
jeremie-lucca
approved these changes
Sep 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Components opened with LuModal/LuSidepanel can provide an Observable value for
title/submitLabel/cancelLabel.