Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New component: viewTabs #2498

Open
wants to merge 8 commits into
base: rc
Choose a base branch
from
Open

New component: viewTabs #2498

wants to merge 8 commits into from

Conversation

vvalentin-lucca
Copy link
Contributor

@vvalentin-lucca vvalentin-lucca commented Jan 9, 2024

Description

closes #2492



Capture d’écran 2024-01-09 à 17 18 09

@vvalentin-lucca vvalentin-lucca added the 🔖✨ Feature New feature (even a very small one) label Jan 9, 2024
@vvalentin-lucca vvalentin-lucca requested a review from a team as a code owner January 9, 2024 16:18
@c-3po c-3po bot added the 📖 Documentation changes Requires a Prisme update label Jan 9, 2024
@LuccaIntegration
Copy link

@CCNET-iLucca
Copy link

Tests d'interfaces

@jeremie-lucca jeremie-lucca added the 🎨 Design sync Discussions with design are required label Jan 9, 2024
@jeremie-lucca
Copy link
Contributor

🎨 Need design sync on component name

@LuccaIntegration
Copy link

@CCNET-iLucca
Copy link

Tests d'interfaces

@vvalentin-lucca vvalentin-lucca changed the title New component: tabs New component: viewTabs Jan 22, 2024
@LuccaIntegration
Copy link

@CCNET-iLucca
Copy link

Tests d'interfaces

packages/scss/src/components/index.scss Outdated Show resolved Hide resolved
font: inherit;
}

.viewTabsPanel {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to have a specific element as container?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Panels are embedded in the component to manage their deactivated and focused states.

@LuccaIntegration
Copy link

@CCNET-iLucca
Copy link

Tests d'interfaces

@LuccaIntegration
Copy link

@CCNET-iLucca
Copy link

Tests d'interfaces

@LuccaIntegration
Copy link

@CCNET-iLucca
Copy link

Tests d'interfaces

@jeremie-lucca jeremie-lucca added this to the 17.4 milestone Feb 13, 2024
@jeremie-lucca jeremie-lucca removed this from the 17.4 milestone Mar 29, 2024
@LuccaIntegration
Copy link

@CCNET-iLucca
Copy link

Tests d'interfaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Documentation changes Requires a Prisme update 🔖✨ Feature New feature (even a very small one) 🎨 Design sync Discussions with design are required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New component] Tabs
5 participants