-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show index table link #2838
base: rc
Are you sure you want to change the base?
Show index table link #2838
Conversation
I find this change somewhat weird because
I think that for it to realy works, we should embed the content of every column into a link and find a way to provide some context to screen reader, like "show details", while also preventing redundancy and tab hell. |
@BertrandPodevin I agree with you. We think it's a better solution than the completely hidden version of the link, but it's still not perfect. We thought of putting several links in each column, with a |
Maybe a https://developer.mozilla.org/fr/docs/Web/Accessibility/ARIA/Roles/link_role |
No, it overwrites the |
Even though lines are supposed to be clickable since we are on Index Tables, some are not yet implemented with a link and moving to a Would changing the pointer to only the parts that are really clickable help for discovery? Clicking anywhere on the row could still open as expected by us, but the UI feedback would actually reflect the semantic of the elements being hovered. |
95f4035
to
1596ef0
Compare
Description
Users have expressed the need to be able to open links in tables to new tabs (via the right-click menu, for example).
To do this, these links must not be hidden and must be visible in the interface.
.indexTable-body-row-cell-action
is therefore deprecated and replaced by.indexTable-body-row-cell-link
, which is its unmasked equivalent, and following @BertrandPodevin's idea, we extend this link so that it can be operated on the whole line, without requiring anoverflow: hidden
,z-index
, or superimposing itself on other interactive elements.