Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows named pipes #236

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Fix Windows named pipes #236

merged 1 commit into from
Oct 9, 2023

Conversation

furrycoding
Copy link
Contributor

On connected callback was called too early(overlapped wasn't awaited)
Also added a DisconnectNamedPipe during destruction

@furrycoding
Fix named pipes
ceafc06 
On connected callback was called too early(overlapped wasn't awaited)
Also added a DsiconnectNamedPipe during destruction
@danwillm danwillm self-requested a review October 9, 2023 10:14
danwillm
danwillm approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@danwillm danwillm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this.

@danwillm danwillm enabled auto-merge (squash) October 9, 2023 10:16
@danwillm danwillm disabled auto-merge October 9, 2023 10:23
@danwillm danwillm merged commit 6521106 into LucidVR:develop Oct 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwillm danwillm danwillm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@furrycoding @danwillm