Use Response.rawBody when throwing ParseError

LuckboxGG · Apr 20, 2021 · 278515f · 278515f
1 parent 418982a
commit 278515f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/src/GotHttpAdapter.ts b/src/GotHttpAdapter.ts
@@ -131,7 +131,7 @@ class GotHttpAdapter implements HttpAdapter {
     if (err instanceof GotParseError) {
       throw new ParseError({
         message: err.message.split(/\sin\s+"?https?:\/{2}/i, 1)[0],
-        responseBody: err.response.body,
+        responseBody: err.response.rawBody.toString(),
       });
     }
 

diff --git a/src/errors/ParseError.ts b/src/errors/ParseError.ts
@@ -1,12 +1,12 @@
-type ConstructorParams<ResponseBodyType = unknown> = {
+type ConstructorParams = {
   message: string;
-  responseBody: ResponseBodyType;
+  responseBody: string;
 }
 
-class ParseError<ResponseBodyType = unknown> extends Error {
-  public readonly responseBody: ResponseBodyType;
+class ParseError extends Error {
+  public readonly responseBody: string;
 
-  constructor(params: ConstructorParams<ResponseBodyType>) {
+  constructor(params: ConstructorParams) {
     super(params.message);
 
     this.name = 'ParseError';

diff --git a/src/tests/GotHttpAdapter.test.ts b/src/tests/GotHttpAdapter.test.ts
@@ -199,7 +199,7 @@ describe('GotHttpAdapter', () => {
         message: 'Unexpected token < at position 10 in "http://example.com"',
         name: 'ParseError',
         response: {
-          body: 'Invalid JSON',
+          rawBody: Buffer.from('Invalid JSON'),
         },
       });
 
@@ -383,7 +383,7 @@ describe('GotHttpAdapter', () => {
         message: 'Unexpected token < at position 10 in "http://example.com"',
         name: 'ParseError',
         response: {
-          body: 'Invalid JSON',
+          rawBody: Buffer.from('Invalid JSON'),
         },
       });