Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull requests do not have acces to TG_BOT_KEY #43

Closed
LuckyTurtleDev opened this issue Jan 17, 2024 · 1 comment
Closed

Pull requests do not have acces to TG_BOT_KEY #43

LuckyTurtleDev opened this issue Jan 17, 2024 · 1 comment

Comments

@LuckyTurtleDev
Copy link
Owner

Pull requests do not have access to TG_BOT_KEY. This let the ci fail on them.

Happen in #42
@msrd0
Copy link
Collaborator

msrd0 commented Jan 17, 2024

Do you want pull requests to be able to extract the tg bot key?

It might be better to set up your own proxy that replaces a "dummy" key with the actual key, but only for the one request the ci will make, and never expose the actual key to potentially untrusted workloads.

LuckyTurtleDev added a commit that referenced this issue Apr 18, 2024
@LuckyTurtleDev
do not run ignored test on pr; see #43
c218a31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msrd0 @LuckyTurtleDev