Port to 1.19 #5
Merged
Port to 1.19 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Motschen <motschen@midnightdust.eu>
|
This PR deals with issue #3 |
Lucxjo
requested changes
Jul 8, 2022
There was a problem hiding this comment.
All changes look good. The version of the mod bundle may need changing back but I'll do this later once I've checked a couple of things. Mod needs to be confirmed to run by 2022-07-10 (that's a me job). Hopeful release of 1.19 version by 2022-07-10.
Thanks for your contributions @Motschen!
Signed-off-by: Motschen <motschen@midnightdust.eu>
Lucxjo
approved these changes
Jul 8, 2022
|
Changed base branch to develop. I need to change a couple of things before release. |
|
@all-contributors please add @Motschen for code |
|
I've put up a pull request to add @Motschen! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Motschen motschen@midnightdust.eu
All of the code changes were done completely by myself.
Sorry for having to close the last PR, I'm using GitHub Desktop and couldn't find out how to rebase the commit.