Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to clarify instructions #6

Merged
merged 1 commit into from Sep 29, 2019
Merged

Conversation

mrexodia
Copy link
Contributor

For me it was quite difficult to follow the instructions, especially without having used Project64 in the past. I updated the instructions to (hopefully) clarify some things so it's easier to new people to enjoy this rom.

@LuigiBlood
Copy link
Owner

I won't really merge that as I really want to have instructions that works for every version, including Japanese, Development, everything.

@mrexodia
Copy link
Contributor Author

Alright, I will do some updates to make it more generic for the disk expansion then. Could you be a bit more specific about which parts need to be more generic?

While I do think it’s good to strive for generic instructions, I also think it’s good to sometimes have a concrete example that people can follow. I read about this rom on n64today and wanted to try it out, but it took me much longer than I wanted, which is why I wanted to update the instructions.

@LuigiBlood
Copy link
Owner

LuigiBlood commented Sep 29, 2019

The step by step patching instructions could be more generic to be honest.

That said the disk instructions are so much better written but then I have the issue that I don't necessarily want to link 64dd.org for concerns that I have with Nintendo and the mod's attention just to make it even easier...

@mrexodia mrexodia force-pushed the patch-1 branch 2 times, most recently from 84562f8 to 5188954 Compare September 29, 2019 15:12
@LuigiBlood
Copy link
Owner

Also I want to deal with the case where user has a ROM that's not big endian since No-Intro was very stupid about this stuff at one point...

@mrexodia
Copy link
Contributor Author

I have updated the disk instructions to better line up with the original wording (eg no mention of 'American') and also removed the download link.

With regards to the step by step instructions being generic, I think the paragraph above describes things generically enough. I updated the title to clarify this is an example. The audience for this step-by-step instruction (in my mind) is enthusiasts who just want to play the mod. If you want I can create specific instructions for each ROM version, because being generic in an example only hurts the instructional value.

@LuigiBlood
Copy link
Owner

LuigiBlood commented Sep 29, 2019

I'm fine with this, but I really want a case where the patch doesn't work because of the ROM endianness which is no one's fault and because ROM sites suck sometimes.

That said I really appreciate this as I'm just terrible at writing instructions as you can see.

@mrexodia
Copy link
Contributor Author

I just tried to apply the wrong patch to my rom and I got this:

fail

Does that cover your concerns?

@LuigiBlood
Copy link
Owner

Nope people just won't know what to do when the endianness is wrong even then it's a legit OoT ROM that's identical in content. That's why I mentioned Tool64.

For me it was quite difficult to follow the instructions, especially without having used Project64 in the past. I updated the instructions to (hopefully) clarify some things so it's easier to new people to enjoy this rom.
@mrexodia
Copy link
Contributor Author

I updated the instructions to try and cover this scenario in more depth.

@LuigiBlood
Copy link
Owner

This seems fine. I guess I'll merge this.

@mrexodia
Copy link
Contributor Author

Great, thanks for your work on the game!

@LuigiBlood LuigiBlood merged commit 6d25b4f into LuigiBlood:master Sep 29, 2019
@mrexodia mrexodia deleted the patch-1 branch September 29, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants