Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: append null type under IContent #79

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix: append null type under IContent #79

merged 1 commit into from
Aug 18, 2023

Conversation

cjxe
Copy link
Contributor

@cjxe cjxe commented Aug 18, 2023

We can extend the IContent type with null for more flexibility

Why?

APIs return the null value when they return nothing. In this case, the browser can receive a key-value pair with null value. Then, we can store this null value in a new Excel sheet (even if it's null); and then we won't receive a type error just because some key's value of some content is null

How?

In this PR, I appended the null type under IContent type

@cjxe cjxe changed the title fix: add null type to IContent fix: append null type under IContent Aug 18, 2023
@LuisEnMarroquin LuisEnMarroquin merged commit daeee56 into LuisEnMarroquin:main Aug 18, 2023
1 check passed
@cjxe cjxe deleted the fix/ented-IContent-type branch August 18, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants