Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE-57] Base Version of Shell Buttons #64

Merged
merged 3 commits into from
Sep 30, 2020
Merged

[ISSUE-57] Base Version of Shell Buttons #64

merged 3 commits into from
Sep 30, 2020

Conversation

LuisValgoi
Copy link
Owner

@LuisValgoi LuisValgoi commented Sep 30, 2020 •
edited
Loading

Description

This PR adds the base for the buttons at the shell implemented with IOC.
Its not the full implementation, its only the base

Dependency

be on the right branch

Config

Are you adding a configuration file?

  • [ ] Have you updated the publish scripts?

Are you adding a new feature

  • Have you updated the README.md?
    Not for now

Testing

yarn test or yarn mock

Image

Screen Shot 2020-09-30 at 15 24 07

Automated Tests

  • Select this if your code has automated Tests for it.

References

@LuisValgoi LuisValgoi self-assigned this Sep 30, 2020
@lpohren lpohren merged commit 63d7488 into master Sep 30, 2020
@LuisValgoi LuisValgoi mentioned this pull request Sep 30, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpohren lpohren lpohren approved these changes

Assignees

@LuisValgoi LuisValgoi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LuisValgoi @lpohren