Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-9] Feature of Formik + Yup Sample #68

Merged
merged 40 commits into from Oct 5, 2020

Conversation

LuisValgoi
Copy link
Owner

@LuisValgoi LuisValgoi commented Oct 3, 2020

Description

This PR:

  • adds the TodoEdit route for edition of the Todo. All of that, integrated with yup and formik.
  • adds atom Form element with the intention to wrap the span & erros of it once used in forms.
  • adds more properties to the TODO response so the sample could be more truth.
  • adds the NavBack element
  • refactors the usage of children components by using ...props
  • refactors a little bit the routes/routing (api and browser)
  • refactors the Providers engine by creating inheritance
  • refactors the util folder so it could be more understandable and more cohesive

Dependency

yarn install

Config

Are you adding a configuration file?

  • Have you updated the publish scripts?

Are you adding a new feature

  • Have you updated the README.md?

Testing

yarn mock or yarn test or yarn test:ci

Automated Tests

  • Select this if your code has automated Tests for it.
    There

References

#9

@LuisValgoi LuisValgoi changed the title [FEAT-9 [ISSUE-9] Feature of Formik + Yup Sample Oct 3, 2020
@LuisValgoi LuisValgoi self-assigned this Oct 3, 2020
@LuisValgoi LuisValgoi added the feature New feature or request label Oct 3, 2020
@LuisValgoi
Copy link
Owner Author

LuisValgoi commented Oct 5, 2020

@marceloschreiber git mv saving lifes. Thank you so much man

src/pages/Todo/Edit/TodoEditForm.js Outdated Show resolved Hide resolved
src/pages/Todo/Edit/TodoEditForm.js Outdated Show resolved Hide resolved
src/pages/Todo/Edit/TodoEdit.js Outdated Show resolved Hide resolved
src/routes/Routes.js Show resolved Hide resolved
@marceloschreiber
Copy link
Collaborator

I also noticed that not all texts are using i18n. Do you want me to change that?

@viniciussdahmer viniciussdahmer mentioned this pull request Oct 5, 2020
3 tasks
@LuisValgoi
Copy link
Owner Author

LuisValgoi commented Oct 5, 2020

I also noticed that not all texts are using i18n. Do you want me to change that?

I have double check and I couldn't find anything.

Just a headsup:
The components which are under ...pages must not have i18n since are pages for examples.
All the others, must have though.

@marceloschreiber marceloschreiber merged commit afc5278 into master Oct 5, 2020
@marceloschreiber
Copy link
Collaborator

The components which are under ...pages must not have i18n since its page of examples only.
All the others, must have though.

Makes sense

@LuisValgoi LuisValgoi deleted the feat-formik-refactored branch October 5, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants