Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-70] Error during create-react-app #72

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

marceloschreiber
Copy link
Collaborator

@marceloschreiber marceloschreiber commented Oct 5, 2020

Description

Initially investigating the error of this #70.

The error happens because we have husky in our template.json which causes the first commit to fail. To solve this is necessary to perform a manual step after using create-react-app. Since we'd already need to perform a manual step to suppress the error I added a node script that:

  • Add husky to package.json
  • Move the development dependencies to devDependencies on package.json
  • Delete itself after execution

Now projects that use this seed can use yarn install --prod to save time during deployment.

Dependency

N/A

Config

Are you adding a configuration file?

  • Have you updated the publish scripts?

Are you adding a new feature

  • Have you updated the README.md?

Testing

npx create-react-app PROJEC_NAME --template file:ui5-webcomponents-react-seed and then follow the README.md.

Automated Tests

  • Select this if your code has automated Tests for it.

References

Copy link
Owner

@LuisValgoi LuisValgoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@marceloschreiber marceloschreiber merged commit 35ee399 into master Oct 7, 2020
@marceloschreiber marceloschreiber deleted the build-post-create-script branch October 7, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants