Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add support for time.Time #20

Merged
merged 2 commits into from Feb 15, 2024
Merged

Conversation

bouroo
Copy link
Contributor

@bouroo bouroo commented Feb 15, 2024

No description provided.

@LukaGiorgadze LukaGiorgadze added the enhancement New feature or request label Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c14e57) 100.00% compared to head (d578c13) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          108       113    +5     
=========================================
+ Hits           108       113    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LukaGiorgadze
Copy link
Owner

Thank you @bouroo,
It misses a negative test case and coverage dropped a little bit. I would be happy if you could add one more test case to cover 100%. Or I can add it later not a big deal.

@bouroo
Copy link
Contributor Author

bouroo commented Feb 15, 2024

@LukaGiorgadze
Ah, I'll add test case tomorrow and let you know when all done.

@bouroo
Copy link
Contributor Author

bouroo commented Feb 15, 2024

@LukaGiorgadze
unknowType test case added

@LukaGiorgadze LukaGiorgadze merged commit 14dc77d into LukaGiorgadze:main Feb 15, 2024
7 checks passed
@bouroo
Copy link
Contributor Author

bouroo commented Apr 1, 2024

@LukaGiorgadze could you please tag/release this merge?

@LukaGiorgadze
Copy link
Owner

@bouroo Sure will be released this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants