Add extra (currently no-op) args to support IntelliJ Rust #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasKalbertodt
requested changes
Jan 29, 2023
| #[arg(long = "show-output")] | ||
| pub show_output: bool, | ||
|
|
||
| /// Enable nightly-only flags |
There was a problem hiding this comment.
I think this should say something like this:
Suggested change
| /// Enable nightly-only flags | |
| /// No-op, ignored. Flag only exists for CLI compatibility with libtest. |
The libtest description doesn't really make sense in the context of libtest-mimic.
| @@ -46,6 +46,14 @@ pub struct Arguments { | |||
| #[arg(long = "nocapture", help = "No-op (libtest-mimic always runs in no-capture mode)")] | |||
| pub nocapture: bool, | |||
|
|
|||
| /// No-op, ignored (libtest-mimic doesn't support this) | |||
There was a problem hiding this comment.
Suggested change
| /// No-op, ignored (libtest-mimic doesn't support this) | |
| /// No-op, ignored. libtest-mimic does not currently capture stdout. |
| /// Possible values for the `-Z` option | ||
| #[derive(Debug, Clone, Copy, PartialEq, Eq, ValueEnum)] | ||
| pub enum UnstableFlags { | ||
| /// Allow use of experimental features |
There was a problem hiding this comment.
Similarly, I think I would just remove this line. As this flag is completely ignored, using the libtest description will likely confuse people.
|
As I haven't heard back, I will close this PR. If you want to take another stab at this, feel free to reopen or open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially gets us to working in IntelliJ Rust - #25.
When we do JSON support we should gate it behind
-Z unstable-optionsas the json format isn't stable yet. This matches the official libtest behaviour.