Skip to content

Commit

Permalink
Fix settings propagation
Browse files Browse the repository at this point in the history
  • Loading branch information
LukasZahradnik committed May 8, 2024
1 parent 99cb0e4 commit 7f2b6cb
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 5 deletions.
2 changes: 1 addition & 1 deletion neuralogic/__version__.py
@@ -1 +1 @@
__version__ = "0.7.14"
__version__ = "0.7.15"
15 changes: 11 additions & 4 deletions neuralogic/core/settings/__init__.py
Expand Up @@ -32,6 +32,8 @@ def __init__(
self.params.pop("self")
self._proxies: weakref.WeakSet[SettingsProxy] = weakref.WeakSet()

self.kw_params = {}

@property
def iso_value_compression(self) -> bool:
return self.params["iso_value_compression"]
Expand Down Expand Up @@ -140,19 +142,24 @@ def create_proxy(self) -> SettingsProxy:
proxy = SettingsProxy(**self.params)
self._proxies.add(proxy)

for k, v in self.kw_params.items():
proxy[k] = v

return proxy

def create_disconnected_proxy(self) -> SettingsProxy:
return SettingsProxy(**self.params)
proxy = SettingsProxy(**self.params)
for k, v in self.kw_params.items():
proxy[k] = v
return proxy

def __setitem__(self, key, value):
for proxy in self._proxies.copy():
proxy[key] = value
self.kw_params[key] = value

def __getitem__(self, item):
for proxy in self._proxies.copy():
return proxy[item]
raise ValueError("No Java background settings instance has been yet initialized")
return self.kw_params[item]

def _update(self, parameter: str, value: Any) -> None:
if parameter not in self.params:
Expand Down

0 comments on commit 7f2b6cb

Please sign in to comment.