Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drawio_args option #14

Closed
wants to merge 2 commits into from
Closed

Add drawio_args option #14

wants to merge 2 commits into from

Conversation

LukeCarrier
Copy link
Owner

@LukeCarrier LukeCarrier commented Apr 18, 2020

This allows easily passing the --no-sandbox option to the Draw.io executable during export, thus making it much easier to run in containerised environments.

Fixes #12

@LukeCarrier LukeCarrier self-assigned this Apr 18, 2020
Copy link
Owner Author

@LukeCarrier LukeCarrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there...

mkdocsdrawioexporter/exporter.py Show resolved Hide resolved
mkdocsdrawioexporter/tests/exporter.py Outdated Show resolved Hide resolved
@LukeCarrier LukeCarrier mentioned this pull request Apr 18, 2020
2 tasks
@LukeCarrier LukeCarrier marked this pull request as ready for review April 18, 2020 22:55
@LukeCarrier LukeCarrier added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 18, 2020
@LukeCarrier LukeCarrier added this to the 0.6.0 milestone Apr 18, 2020
This allows easily passing the --no-sandbox option to the Draw.io
executable during export, thus making it much easier to run in
containerised environments.

Fixes #12
@michaelsabijon
Copy link

Go Mister Luke!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to run within Docker
2 participants