Support Docker image for i386 and arm32v7 architectures #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -119,6 +120,6 @@ jobs: | |||
| --tag $DOCKER_REPO:latest \ | |||
| --build-arg=BASE_IMAGE=rust:$RUST_IMAGE_TAG \ | |||
| --build-arg=CHEF_TAG=$CHEF_PACKAGE_VERSION \ | |||
| --platform linux/amd64,linux/arm64 \ | |||
| --platform linux/amd64,linux/arm64,linux/386,linux/arm/v7 \ | |||
There was a problem hiding this comment.
Don't we have the same problem here with respect to Alpine?
There was a problem hiding this comment.
latest should always be Debian, isn’t it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #182
Description of changes: Add i386 and arm32v7 to Docker image build platform. (Following upstream image's architectures)
Official rust docker image is depends on rustup. And rustup doesn't support i386 and arm/v7 for musl(alpine) target.
This PR adds build target 'i386' and 'arm/v7' on non-alpine target. According to #182 (comment), this should be ok.
Note: latest is always Debian based.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.