Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Docker image for i386 and arm32v7 architectures #226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support Docker image for i386 and arm32v7 architectures #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,14 @@ jobs:
CHEF_PACKAGE_VERSION=${{ steps.package_version.outputs.result }}
CHEF_IMAGE=$DOCKER_REPO:$CHEF_PACKAGE_VERSION-rust-$RUST_IMAGE_TAG
CHEF_IMAGE_LATEST=$DOCKER_REPO:latest-rust-$RUST_IMAGE_TAG
CHEF_IMAGE_PLATFORM="linux/amd64,linux/arm64$(if [[ "$RUST_IMAGE_TAG" != *alpine* ]]; then echo ",linux/386,linux/arm/v7"; fi)"

docker buildx build \
--tag $CHEF_IMAGE \
--tag $CHEF_IMAGE_LATEST \
--build-arg=BASE_IMAGE=rust:$RUST_IMAGE_TAG \
--build-arg=CHEF_TAG=$CHEF_PACKAGE_VERSION \
--platform linux/amd64,linux/arm64 \
--platform $CHEF_IMAGE_PLATFORM \
--push \
./docker
-
Expand All @@ -119,6 +120,6 @@ jobs:
--tag $DOCKER_REPO:latest \
--build-arg=BASE_IMAGE=rust:$RUST_IMAGE_TAG \
--build-arg=CHEF_TAG=$CHEF_PACKAGE_VERSION \
--platform linux/amd64,linux/arm64 \
--platform linux/amd64,linux/arm64,linux/386,linux/arm/v7 \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have the same problem here with respect to Alpine?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest should always be Debian, isn’t it?

--push \
./docker