Add all articles missing endpoints. Fix a bug with local re-exports #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now model all the endpoints under the
/articlesprefix in the Realworld example.I've also re-organised the Realworld example to go for the "1 file 1 route handler" model, which makes things a bit more obvious in terms of code organisation.
When doing so, I unveiled a bug in our handling of local glob re-exports (i.e.
use internal_module::*): we were adding the name of the source module to the path of the discovered items.The bug has been fixed, there is a regression test and now everything works as expected.