Prevent infinite loop when using reserved fields #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/formatting_layer.rs
Outdated
Comment on lines
319
to
331
| let current_span = if event.is_root() { | ||
| None | ||
| } else { | ||
| // Events do not necessarily happen in the context of a span, hence lookup_current | ||
| // returns an `Option<SpanRef<_>>` instead of a `SpanRef<_>`. | ||
| ctx.lookup_current() | ||
| }; |
There was a problem hiding this comment.
I'm not sure this is correct.
I think we should:
- Look up the current span if https://docs.rs/tracing/latest/tracing/event/struct.Event.html#method.is_contextual returns true
- Look up the parent if https://docs.rs/tracing/latest/tracing/event/struct.Event.html#method.parent returns
Some - Set it to
Noneif all the above didn't work
There was a problem hiding this comment.
Right, I think that makes sense.
This was referenced Jul 16, 2023
abusch
force-pushed
the
fix_infinite_loop
branch
from
2d5dfc2
to
615ef4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at fixing #33 by explicitly setting
parent: Nonewhen callingtracing::debug!()inBunyanFormattingLayer. Also check whether the event is a "root" event before resolving the "current context" inon_event().Testing this was tricky, as it turns out the infinite loop only happens if the subscriber is installed globally (i.e with
tracing::subscriber::set_global_default()). When using a thread-local subscriber, such as withtracing::subscriber::with_default(),tracingprevents you from re-entrantly acquiring the subscriber, returning a dummyNONEsubscriber the second time (which means the logs fromBunyanFormattingLayerare always lost in that case). See https://github.com/tokio-rs/tracing/blob/v0.1.x/tracing-core/src/dispatcher.rs#L384closes: #33