Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NBN Technology: undefined error for Tasmanian premises #2

Closed
BK1233 opened this issue Apr 28, 2022 · 7 comments
Closed

NBN Technology: undefined error for Tasmanian premises #2

BK1233 opened this issue Apr 28, 2022 · 7 comments

Comments

@BK1233
Copy link

BK1233 commented Apr 28, 2022

Hey Luke,

Thanks for making this extension!

Over the last few weeks, I have noticed when looking at premises located in Tasmania, they all come up with an NBN Technology: undefined error message. I will leave an example below and a link to a home for sale.

For reference, I also use another extension for checking NBN technology types. https://chrome.google.com/webstore/detail/nbn-availability-checker/dphlehoebkdjgennbalpfpjnhjojcceo

https://www.realestate.com.au/property-house-tas-lenah+valley-139096555

Screenshot_28

@LukePrior
Copy link
Owner

Thanks for the report I'll have a look into what's causing this and see if I can find a solution.

@LukePrior
Copy link
Owner

Note to myself the API manages to match the address to a LocID LOC000015981077 using the NBN address resolution API.

The error occurs with the MyRepublic API and appears to be due to MyRepublic not servicing any locations in Tasmania.

The API should fallback to the Uniti Wireless API where it would find that the address is in fact serviced by the NBN.

I think the issue is that as the MyRepublic API isn't returning an error and just a response of

{"technology":null}

that the fallback isn't triggered.

The best immediate fix will be to add a case to accommodate this fallback.

I am hoping to revise the API in future to use a more robust source but that is likely still a ways away.

@LukePrior
Copy link
Owner

Ok, that has been implemented with the extension now showing Unkown instead of undefined:

image

As previously mentioned I will need to wait for a new API until this can be properly resolved so I will leave this issue open.

@Hongie84
Copy link

Hi Luke, Great extension.

Is there a way to display the NBN status on the initial realestate.com list page, rather than only on the individual listing?

@LukePrior
Copy link
Owner

Hi @Hongie84,

I'm glad you like the extension. I currently support the saved property pages for real-estate.com.au and domain.com.au. Is this what you were looking for on the homepage?

@Hongie84
Copy link

Hongie84 commented May 30, 2022 via email

@LukePrior
Copy link
Owner

Ok, I will look into adding that.

Notes to self:

  • fix realestate.com.au single page display
  • use list view for search page

@BK1233 BK1233 closed this as completed Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants