New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in child tag validation #64

Closed

sidkshatriya opened this issue May 19, 2016 · 1 comment

Assignees

Labels

Phase 2

Contributor

sidkshatriya commented May 19, 2016

Child tag validation code is being called from wrong location
number of child tags is not being compared properly with number of mandatory child tags

This came to light when run test on:
https://github.com/ampproject/amphtml/blob/27ee29ffc3d809fcc8143044d22df9d176ad8169/extensions/amp-accordion/0.1/test/validator-amp-accordion.html

And comparing output against:
https://github.com/ampproject/amphtml/blob/27ee29ffc3d809fcc8143044d22df9d176ad8169/extensions/amp-accordion/0.1/test/validator-amp-accordion.out

Fix this bug and add this test to the full-html tests directory

sidkshatriya self-assigned this

sidkshatriya added the Phase 2 label

sidkshatriya mentioned this issue

64 child tag validation #65

Merged

Contributor Author

sidkshatriya commented May 19, 2016

This is fixed. Test has also been added (see pull request). Closing.

sidkshatriya closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment