Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add layout validation #83

Closed
sidkshatriya opened this issue Jun 1, 2016 · 1 comment
Closed

Add layout validation #83

sidkshatriya opened this issue Jun 1, 2016 · 1 comment
Assignees
@sidkshatriya
Labels
Phase 2

Comments

@sidkshatriya
Copy link
Contributor

Add Layout validation to our library by porting over relevant code from the amphtml project.

To know what layouts in AMP are, here is a useful link:
https://github.com/ampproject/amphtml/blob/master/spec/amp-html-layout.md

(This is subticket of #35)
@sidkshatriya sidkshatriya self-assigned this Jun 1, 2016
This was referenced Jun 1, 2016
Closed
Merged
@sidkshatriya
Copy link
Contributor Author

sidkshatriya commented Jun 2, 2016 •
edited
Loading

Layout validation feature is complete and was merged to master.

There are 2 new layout validation related tests from the amphtml project (See PR #84)

Closing ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sidkshatriya sidkshatriya

Labels
Phase 2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sidkshatriya