Add the ability to skip tests that require an internet connection #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g. tests that make oembed calls or need image size determination) - Set environment variable AMP_TEST_SKIP_INTERNET=1 and then run `phpunit tests` and the tests that require an internet connection will be skipped
|
This becomes useful in cases when you want to get an idea of the total runtime of the test suite without worrying about network download time influencing the result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you want to run tests that don't require an internet connection. This PR adds that ability.
How to use
Set environment variable AMP_TEST_SKIP_INTERNET=1 and then run
phpunit testsand the teststhat require an internet connection will be skipped
As a shortcut from the command line
unset AMP_TEST_SKIP_INTERNET(or set it to 0) if you don't want internet tests to be skipped