Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating multiple fixes upstream #164

Merged
merged 6 commits into from
Feb 13, 2017
Merged

Migrating multiple fixes upstream #164

merged 6 commits into from
Feb 13, 2017

Commits on Feb 9, 2017

  1. Badly formatted youtube URLs cause a parse error 

    The DOM parser throws away invalid HTML.

When you have http://youtube.com/embed/_FlV6pgwlrk&list=123 then
the `IframeYouTubeTagTransformPass::getYouTubeCode()` will match the
ID as `_FlV6pgwlrk&list=123` but since the ampersand isn't in a
proper HTML format (`&`), then DOM will throw this whole
element away.

I wrote a test to make sure noone breaks this in the future.
    Sigurdur Gudbrandsson committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    ad852d3 View commit details
    Browse the repository at this point in the history

  2. fix-image-height-missing

    @Deuh
    Deuh authored and Sigurdur Gudbrandsson committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    9bfcb27 View commit details
    Browse the repository at this point in the history

  3. youtube-start-time : Fix IframeYotubeTransformPass::getYouTubeCode()

    @Deuh
    Deuh authored and Sigurdur Gudbrandsson committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    514a743 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2017

  1. Add amp-anim for animated image + remove non-converted img tag in Amp… 

    …ImgFixPass
    @Deuh
    Deuh authored and Sigurdur Gudbrandsson committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    30fbd97 View commit details
    Browse the repository at this point in the history

  2. Fixing builds to pass testing

    Sigurdur Gudbrandsson committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    211b8f4 View commit details
    Browse the repository at this point in the history

  3. Allow Travis builds to fail on PHP nightly

    Sigurdur Gudbrandsson committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    0e89046 View commit details
    Browse the repository at this point in the history