Update masterminds and fix options #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I tried allowing masterminds/html5 2.7.1 and that broke tests. So I stopped with 2.6. I didn't try to figure out what was broken. |
|
Looks like Drupal 9 might want masterminds/html5 2.7, https://www.drupal.org/project/drupal/issues/3088369#comment-13314969. But it apparently only has a conflict with masterminds/html5 < 2.6. So I imagine this will be sufficient. But it also might be nice to figure out what it takes for 2.7 to work, if anyone has an idea. The broken test is a failure to render html exactly as expected. The only change I see that might be the issue is https://github.com/Masterminds/html5-php/pull/168/files. [Edit] Tried again later and there is no problem, and tests pass here as well, so expanding the version seems ok. |
karens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation from a forked PR, #249. This code: