Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

79 line numbers css issues #80

Merged
merged 16 commits into from
Jul 1, 2016
Merged

Conversation

sidkshatriya
Copy link
Contributor

See #79

(These changes must go with changes to the changes to the lullabot fork https://github.com/Lullabot/PHP-CSS-Parser )

@sidkshatriya sidkshatriya self-assigned this May 31, 2016
@sidkshatriya
Copy link
Contributor Author

This is already working quite well ( compare with #78 (comment) ). See the line numbers outputted for CSS (we didn't have this capability before). Note: Requires custom version of sabberworm/php-css-parser

AMP-HTML Validation Issues and Fixes
-------------------------------------
FAIL

<style amp-custom> on line 27
- The text (CDATA) inside tag 'style amp-custom' contains 'CSS -amp- class name prefix', which is disallowed.
   [code: CDATA_VIOLATES_BLACKLIST  category: AUTHOR_STYLESHEET_PROBLEM see: https://www.ampproject.org/docs/reference/spec.html#stylesheets]
- The text (CDATA) inside tag 'style amp-custom' contains 'CSS !important', which is disallowed.
   [code: CDATA_VIOLATES_BLACKLIST  category: AUTHOR_STYLESHEET_PROBLEM see: https://www.ampproject.org/docs/reference/spec.html#stylesheets]

<style amp-custom> on line 29
- CSS syntax error in tag 'style amp-custom' - saw invalid at rule '@import'.
   [code: CSS_SYNTAX_INVALID_AT_RULE  category: AUTHOR_STYLESHEET_PROBLEM see: https://www.ampproject.org/docs/reference/spec.html#stylesheets]

<style amp-custom> on line 33
- CSS syntax error in tag 'style amp-custom' - saw invalid at rule '@viewport'.
   [code: CSS_SYNTAX_INVALID_AT_RULE  category: AUTHOR_STYLESHEET_PROBLEM see: https://www.ampproject.org/docs/reference/spec.html#stylesheets]

<style amp-custom> on line 39
- CSS syntax error in tag 'style amp-custom' - invalid url protocol 'invalid:'.
   [code: CSS_SYNTAX_INVALID_URL_PROTOCOL  category: AUTHOR_STYLESHEET_PROBLEM see: https://www.ampproject.org/docs/reference/spec.html#stylesheets]

<style amp-custom> on line 48
- CSS syntax error in tag 'style amp-custom' - invalid url protocol 'invalid:'.
   [code: CSS_SYNTAX_INVALID_URL_PROTOCOL  category: AUTHOR_STYLESHEET_PROBLEM see: https://www.ampproject.org/docs/reference/spec.html#stylesheets]

<style amp-custom> on line 51
- CSS syntax error in tag 'style amp-custom' - invalid url protocol 'absolute:'.
   [code: CSS_SYNTAX_INVALID_URL_PROTOCOL  category: AUTHOR_STYLESHEET_PROBLEM see: https://www.ampproject.org/docs/reference/spec.html#stylesheets]

@sidkshatriya
Copy link
Contributor Author

This branch has not been merged yet -- merged the latest master branch and made updates to composer.json to keep things upto date.

@sidkshatriya sidkshatriya merged commit 04c9c93 into master Jul 1, 2016
@sidkshatriya sidkshatriya deleted the 79-line-numbers-css-issues branch July 1, 2016 06:43
@sidkshatriya
Copy link
Contributor Author

This was merged to master. It uses the latest version ^8.0.0 of the sabberworm css parser which contains our patch for line numbers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant