Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #204: Add a task for interacting with Acquia #442

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Issue #204: Add a task for interacting with Acquia #442

wants to merge 10 commits into from

Conversation

justafish
Copy link
Member

@justafish justafish commented Feb 22, 2024 •
edited by mrdavidburns
Loading

relates: #204

@justafish justafish requested a review from YesCT February 22, 2024 10:33
@justafish
Copy link
Member Author

@YesCT would you be able to review this please as you've tested it elsewhere? 😁 🙏

@github-actions github-actions bot had a problem deploying to pantheon-pr-442 February 22, 2024 10:34 Failure
@isholgueras isholgueras mentioned this pull request Feb 24, 2024
Open
isholgueras
isholgueras reviewed Feb 24, 2024
View reviewed changes
Copy link

@isholgueras isholgueras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it and it works fine. The addition of specifying the database works well to me too.

tasks/acquia.yml Show resolved Hide resolved
tasks/acquia.yml Outdated Show resolved Hide resolved
@justafish justafish marked this pull request as draft March 5, 2024 15:19
@github-actions github-actions bot requested a deployment to pantheon-pr-442 March 5, 2024 17:17 In progress
beto-aveiga
beto-aveiga reviewed Mar 8, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
beto-aveiga
beto-aveiga reviewed Mar 8, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@beto-aveiga
Copy link
Collaborator

Hi @justafish,

Fetching the DB worked perfectly on my local. ✅
https://gist.github.com/beto-aveiga/e3877e0c599c2c25a2ff77f4afaa88a6

I'm unclear if you wanted me to test the other commands on this PR.
I think not all commands are easy to test, but I can try.

@justafish @beto-aveiga
Update .github/actions/drainpipe/acquia/deploy/action.yml
abc86f6 
Co-authored-by: Beto Aveiga <luis.aveiga@gmail.com>
justafish and others added 3 commits March 12, 2024 12:33
@justafish @beto-aveiga
Update .github/workflows/TestAcquia.yml
b631e9d 
Co-authored-by: Beto Aveiga <luis.aveiga@gmail.com>
@justafish @beto-aveiga
Update README.md
8ca5fa1 
Co-authored-by: Beto Aveiga <luis.aveiga@gmail.com>
@justafish @beto-aveiga
Update README.md
c580937 
Co-authored-by: Beto Aveiga <luis.aveiga@gmail.com>
@justafish justafish changed the title Issue #204: Add a task for fetching a database from Acquia Issue #204: Add a task for interacting with Acquia Mar 28, 2024
@justafish justafish mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isholgueras isholgueras isholgueras left review comments

@beto-aveiga beto-aveiga beto-aveiga left review comments

@YesCT YesCT Awaiting requested review from YesCT

Assignees
No one assigned
Labels
client affected enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justafish @beto-aveiga @isholgueras @deviantintegral