Olivero-3093249: Implement tables on Olivero proof of concept. #18
Conversation
src/css/components/table.css
Outdated
td, | ||
th { | ||
padding: var(--sp1-5) var(--sp1-5) var(--sp1-5) 0; | ||
text-align: left; /* LTR */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're actually gonna merge a PostCSS plugin that does the RTL stuff. So don't worry about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know!
@mherchel Just pushed out the changes. Can you take a look again? |
@mherchel With the layout issue within FF, may I suggest that instead of having |
I think that might be impossible. 1) We won't be able to float images (and have text wrap) and 2) We can't even guarantee that people will be using tags. |
@mherchel Please see below for the latest changelog made to the PR.
11/20 - Adjust the look and feel of the table As for the odd right padding issue that was seen last week, I realized that it was caused by the |
…n per slack discussion.
@mherchel I've cleaned up the |
@mherchel Just added some adjustments to the linear-gradient direction based on the |
@mherchel When you have a chance, can you take a look at the changes made in this PR? Thanks! |
@mherchel I'm going to merge this down to |
Olivero-3093249: Implement tables on Olivero proof of concept.
What kind of change does this PR introduce? (Bug fix, feature...)
Additional Info