Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a POST to fetch stories #38

Closed
lussoluca opened this issue Jul 17, 2023 · 1 comment
Closed

Use a POST to fetch stories #38

lussoluca opened this issue Jul 17, 2023 · 1 comment

Comments

@lussoluca
Copy link
Contributor

Currently, fetchStoryHtml uses a GET to fetch a story from Drupal.

For stories with a lot of props and slots values, the query string will become too long (see here).

We should convert the fetch request to a POST.

On the Drupal side, we can support both methods; if the fetch is a GET, we can retrieve the params from the query string; if it's a POST, we look in the request content.

lussoluca added a commit to lussoluca/storybook-drupal-addon that referenced this issue Jul 17, 2023
@e0ipso
Copy link
Member

e0ipso commented Jul 31, 2023

The Drupal part is merged. This can happen now.

@e0ipso e0ipso closed this as completed in 1ad6e58 Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants