Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): add ci for beamcoder #2

Merged
merged 2 commits into from
Jan 4, 2024
Merged

feat(*): add ci for beamcoder #2

merged 2 commits into from
Jan 4, 2024

Conversation

stepancar
Copy link

@stepancar stepancar commented Jan 4, 2024

add CI for beamcoder, similar to framefusion.

@stepancar
Copy link
Author

@animanathome , do you remember, publishing of this package is just yarn publish, o did you build something locally?

@antoineMoPa
Copy link

@animanathome , do you remember, publishing of this package is just yarn publish, o did you build something locally?

I think I just published manually, I thought it would just be a temporary repo until Streampunk#113 would be merged. Sadly, I lost hope that the original repo would be maintained at this point.

@antoineMoPa
Copy link

@stepancar do you think we should take more ownership of supporting beamcoder and updating it to newer ffmpeg version? Or you see this repo as temporary before we move on to something like webcodecs?

name: Node.js Package

on:
release:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stepancar can we have it publish when we merge to main branch? I feel like it's a lot of bureaucracy to have to create a release after merging.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antoineMoPa , let's skip it for now? I tried to make it similar to what we have for framefusion

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, makes sense to keep similar and eventually move everything at once to a new workflow.

@stepancar
Copy link
Author

@stepancar do you think we should take more ownership of supporting beamcoder and updating it to newer ffmpeg version? Or you see this repo as temporary before we move on to something like webcodecs?

I see this repo temporary.
I just wanted to fix it and publish, but it's published under your npm account. I decided to move it here in order to reduce entropy

Copy link

@antoineMoPa antoineMoPa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stepancar stepancar merged commit 8fa5baf into main Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants