Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release_v0.2.2 #183

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Release_v0.2.2 #183

merged 3 commits into from
Mar 17, 2023

Conversation

jlaehne
Copy link
Contributor

@jlaehne jlaehne commented Mar 15, 2023

Description of the change

I'd like to push a patch release before the tutorial at the CL-EBIC workshop next week.

Progress of the PR

  • bumped version,
  • updated CHANGELOG.md,
  • ready for review.

@jlaehne jlaehne added this to the v0.2.2 milestone Mar 15, 2023
@ericpre
Copy link
Contributor

ericpre commented Mar 15, 2023

I'd like to push a patch release before the tutorial at the CL-EBIC workshop next week.

Do you think that we should release a hyperspy patch release asap to avoid potential troubles with the random number generation changes in recent version of dask?

@jlaehne
Copy link
Contributor Author

jlaehne commented Mar 15, 2023

I'd like to push a patch release before the tutorial at the CL-EBIC workshop next week.

Do you think that we should release a hyperspy patch release asap to avoid potential troubles with the random number generation changes in recent version of dask?

Haven't looked into the details, but sounds sensible and might not hurt.

@jlaehne
Copy link
Contributor Author

jlaehne commented Mar 15, 2023

I just realized that for a map the new centroid function, similar to e.g. valuemax and indexmax in HyperSpy returns a BaseSignal with 2 navigation dimensions and 0D signal, which theoretically makes sense, but is inconvenient for plotting as it plots including the navigator, which makes little sense for 0D signals, and colormap cannot be changed.

In contrast, estimate_peak_width returns the transposed signal, thus Signal2D object without navigation dimensions, which is more convenient for plotting - and is okay in the sense that it is just an image of values for the different positions.

We should consider making that more consistent also in HyperSpy (e.g. with the 2.0 release), but if we release the centroid function here and then decide to change the behavior again, we unnecessarily break the API.

@jlaehne
Copy link
Contributor Author

jlaehne commented Mar 17, 2023

I changed the centroid output type to Signal2D in #184 and opened an issue for HyperSpy hyperspy/hyperspy#3111

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9db99bd) 100.00% compared to head (31e2aa6) 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #183   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          554       554           
=========================================
  Hits           554       554           
Impacted Files Coverage Δ
lumispy/release_info.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jlaehne jlaehne merged commit ca4d57d into LumiSpy:main Mar 17, 2023
@jlaehne jlaehne deleted the release_v0.2.2 branch July 19, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants