Add CI functionalities #30
Conversation
Add basic CI .yml files
Testing devop pipeline service connection endpoint settings.
Edits on travis setup
* Simplified travis pipelines * Travis leave Linux-only machines * Add coveralls and coverage * Add travis and coveralls badges * Remove Azure pipelines
|
@ericpre I have set TravisCI and Coveralls for the master branch now, dealing with issue #24. I've seen the tests you have written for signal_registration all pass. Let me know if you see any errors as it is the first time I deal with CI. |
There was a problem hiding this comment.
In this PR, there are two travis builds (#22 and #23) which seems to have been triggered on different condition ("on PR" and "on push") and they should be only one to save CI ressources. Not sure, but it may simply be a setting in the LumiSpy/lumispy project on travis.
Regarding azure pipeline, I can't see what is the issue (access denied). I have used it for a couple of repos and it works fine, providing the service connection is set up. If you think something in https://github.com/hyperspy/ci-scripts should be fixed or better documented, please open an issue there.
| matrix: | ||
| include: | ||
| - name: "Linux, 3.8, pip" | ||
| env: export ENV=pip; PIP_SELECTOR="all, tests" |
There was a problem hiding this comment.
If you don't use the "extra" selector for pip install (https://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-extras-optional-features-with-their-own-dependencies), then you don't need to define the PIP_SELECTOR environment variable. In travis/hyperspy, the minimum and optional dependencies are defined in setup.py and we select the ones which are necessary for the travis.
| # Install the package | ||
| # - pip install --upgrade -e .["${PIP_SELECTOR}"] | ||
| - pip install hyperspy | ||
| - pip install pytest-cov coveralls coverage |
There was a problem hiding this comment.
To be more tidy, I would define these optional dependencies using extras_require in setup.py and use the appropriate pip extra selector to install lumispy.
Added TravisCI (with only 2 Linux machines) and Coveralls.