Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black formatting #78

Merged
merged 2 commits into from
Jun 6, 2021
Merged

Black formatting #78

merged 2 commits into from
Jun 6, 2021

Conversation

ericpre
Copy link
Contributor

@ericpre ericpre commented Jun 6, 2021

Progress of the PR

@codecov-commenter
Copy link

Codecov Report

Merging #78 (437b3b3) into master (c7dd36e) will increase coverage by 0.07%.
The diff coverage is 88.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   92.36%   92.43%   +0.07%     
==========================================
  Files          12       12              
  Lines         537      542       +5     
==========================================
+ Hits          496      501       +5     
  Misses         41       41              
Impacted Files Coverage Δ
lumispy/signals/__init__.py 100.00% <ø> (ø)
lumispy/signals/cl_transient.py 100.00% <ø> (ø)
lumispy/signals/el_spectrum.py 100.00% <ø> (ø)
lumispy/signals/luminescence_transient.py 100.00% <ø> (ø)
lumispy/signals/pl_spectrum.py 100.00% <ø> (ø)
lumispy/signals/pl_transient.py 100.00% <ø> (ø)
lumispy/utils/axes.py 84.10% <81.48%> (+0.21%) ⬆️
lumispy/signals/luminescence_spectrum.py 89.20% <83.72%> (ø)
lumispy/signals/cl_spectrum.py 97.01% <86.66%> (ø)
lumispy/release_info.py 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7dd36e...437b3b3. Read the comment docs.

@jlaehne jlaehne merged commit 3b5dc4b into LumiSpy:master Jun 6, 2021
@jlaehne
Copy link
Contributor

jlaehne commented Jun 6, 2021

@ericpre do you have an idea, why only the py3.8 coverage test run fails?

@ericpre
Copy link
Contributor Author

ericpre commented Jun 7, 2021

This build is using the non_uniform_axes branch and there is a bug somewhere, which can be either in join_spectra or the non_uniform_axes branch. It would be good to figure it out!

@jlaehne
Copy link
Contributor

jlaehne commented Jun 7, 2021

Thanks, I did not realize that only this one test is running on the non_uniform_axes branch. Ends up in a nice catch for that branch. Fixed in hyperspy/hyperspy#2765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants