fix(temp-storage): move workingCache to temporary storage (fixes #1136) #1727

JPSchellenberg · 2021-07-27T15:59:09Z

Hey,

I started to work on the issue that the old content is not cleaned up by saving it into the app.getPath('temp') folder. Is this a viable way? @sr258

JPSchellenberg · 2021-07-27T16:12:50Z

I remove the old workingCache directory during the setup process. What do you think?

sr258

The temporary files in the "real" temporary directory aren't deleted at the moment. In LumiPlayer I've done it like this:

app.on('will-quit', (event) => {
    log.debug(`Deleting temporary directory: ${tmpDir}`);
    fsExtra.removeSync(tmpDir);
});

Relevant commit: https://github.com/Lumieducation/LumiPlayer/commit/e9d0dc69c41da1e3ead7aeeb12bbf30f1378a641#

While we're working on this, it would also make sense to rename the "workingCache". The name is a bit confusing and I would simply call it content storage.

sr258 · 2021-07-27T16:53:28Z

server/src/main.ts

@@ -217,7 +218,8 @@ if (!gotSingleInstanceLock) {
        log.info('app is ready');
        const server = await httpServerFactory(
            serverConfigFactory(
-                process.env.USERDATA || app.getPath('userData')


I think we should reuse the serverConfig from above if possible

sr258 · 2021-07-27T16:54:35Z

server/src/main.ts

@@ -110,7 +110,8 @@ if (!gotSingleInstanceLock) {
    app.quit();
 } else {
    const serverConfig = serverConfigFactory(
-        process.env.USERDATA || app.getPath('userData')
+        process.env.USERDATA || app.getPath('userData'),
+        process.env.TEMPDATA || app.getPath('temp')


The temp path is generic and not app specific. In the player, I've appended a directory:
const tmpDir = path.join(app.getPath('temp'), 'lumiplayer')

sr258 · 2021-07-27T16:55:07Z

server/src/boot/setup.ts

@@ -13,8 +13,17 @@ export default async function setup(
    serverConfig: IServerConfig
 ): Promise<void> {
    try {
+        // If the workingCache (prior 0.8.0) still exists in userData remove it. -> https://github.com/Lumieducation/Lumi/pull/1727
+        const workingCachePath = path.join(


The same should be done for the temporary files

sr258

Everything looks fine. I think it makes sense to include this in 0.8.0 after all.

# [0.8.0-beta.7](v0.8.0-beta.6...v0.8.0-beta.7) (2021-08-04) ### Bug Fixes * **deps:** update dependency @material-ui/core to v4.12.3 ([df90203](df90203)) * **deps:** update dependency @testing-library/user-event to v13.2.1 ([00ed45a](00ed45a)) * **deps:** update dependency @types/node to v14.17.6 ([7419e10](7419e10)) * **deps:** update dependency @types/node to v14.17.7 ([7dd68c4](7dd68c4)) * **deps:** update dependency @types/react to v17.0.15 ([748582d](748582d)) * **deps:** update dependency electron-log to v4.4.0 ([5e92358](5e92358)) * **deps:** update dependency electron-log to v4.4.1 ([477a011](477a011)) * **deps:** update dependency electron-updater to v4.4.2 ([c46a25b](c46a25b)) * **deps:** update dependency electron-updater to v4.4.3 ([811e9b8](811e9b8)) * **deps:** update dependency i18next to v20.3.5 ([9d88f16](9d88f16)) * **deps:** update dependency i18next-http-backend to v1.2.8 ([6079000](6079000)) * **deps:** update dependency i18next-http-backend to v1.3.0 ([38e43eb](38e43eb)) * **deps:** update dependency notistack to v1.0.10 ([#1725](#1725)) ([526377b](526377b)) * **deps:** update dependency react-i18next to v11.11.4 ([#1726](#1726)) ([4467cdb](4467cdb)) * **deps:** update dependency redux to v4.1.1 ([89b0dfd](89b0dfd)) * **temp-storage:** move workingCache to temporary storage (fixes [#1136](#1136)) ([#1727](#1727)) ([274dd65](274dd65))

github-actions · 2021-08-04T07:41:04Z

🎉 This PR is included in version 0.8.0-beta.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [0.8.0](v0.7.2...v0.8.0) (2021-08-04) ### Bug Fixes * **app:** localized privacy policy and better Run menu ([#1682](#1682)) ([d7823de](d7823de)) * **boot:** file associations always work ([#1624](#1624)) ([e66c2a4](e66c2a4)) * **deps:** update dependency @lumieducation/h5p-express to v7.5.2 ([142e530](142e530)) * **deps:** update dependency @lumieducation/h5p-express to v8.1.0 ([7749151](7749151)) * **deps:** update dependency @lumieducation/h5p-express to v8.1.1 ([8e4353d](8e4353d)) * **deps:** update dependency @lumieducation/h5p-express to v8.1.2 ([3d4a8db](3d4a8db)) * **deps:** update dependency @lumieducation/h5p-express to v8.1.3 ([a10f7d2](a10f7d2)) * **deps:** update dependency @lumieducation/h5p-html-exporter to v7.5.2 ([06b05ce](06b05ce)) * **deps:** update dependency @lumieducation/h5p-html-exporter to v8.1.0 ([190aaf1](190aaf1)) * **deps:** update dependency @lumieducation/h5p-html-exporter to v8.1.1 ([519bc1f](519bc1f)) * **deps:** update dependency @lumieducation/h5p-html-exporter to v8.1.2 ([c79673e](c79673e)) * **deps:** update dependency @lumieducation/h5p-html-exporter to v8.1.3 ([4c0bd8c](4c0bd8c)) * **deps:** update dependency @lumieducation/h5p-react to v7.5.2 ([9efa8a9](9efa8a9)) * **deps:** update dependency @lumieducation/h5p-react to v8.1.0 ([85dc2cd](85dc2cd)) * **deps:** update dependency @lumieducation/h5p-react to v8.1.1 ([c7b0218](c7b0218)) * **deps:** update dependency @lumieducation/h5p-react to v8.1.2 ([772a6fe](772a6fe)) * **deps:** update dependency @lumieducation/h5p-react to v8.1.3 ([3659560](3659560)) * **deps:** update dependency @lumieducation/h5p-server to v7.5.2 ([#1487](#1487)) ([3cb9d07](3cb9d07)) * **deps:** update dependency @lumieducation/h5p-server to v8.1.0 ([a43341e](a43341e)) * **deps:** update dependency @lumieducation/h5p-server to v8.1.1 ([f27ed94](f27ed94)) * **deps:** update dependency @lumieducation/h5p-server to v8.1.2 ([fcdbaac](fcdbaac)) * **deps:** update dependency @lumieducation/h5p-server to v8.1.3 ([3d82c15](3d82c15)) * **deps:** update dependency @material-ui/core to v4.11.4 ([6fa1412](6fa1412)) * **deps:** update dependency @material-ui/core to v4.12.0 ([83a82f8](83a82f8)) * **deps:** update dependency @material-ui/core to v4.12.1 ([88ae1f9](88ae1f9)) * **deps:** update dependency @material-ui/core to v4.12.2 ([166f3ab](166f3ab)) * **deps:** update dependency @material-ui/core to v4.12.3 ([df90203](df90203)) * **deps:** update dependency @sentry/electron to v2.4.1 ([5db5160](5db5160)) * **deps:** update dependency @sentry/electron to v2.5.0 ([f7ffe9e](f7ffe9e)) * **deps:** update dependency @sentry/electron to v2.5.1 ([06ccfe9](06ccfe9)) * **deps:** update dependency @testing-library/jest-dom to v5.12.0 ([8195799](8195799)) * **deps:** update dependency @testing-library/jest-dom to v5.13.0 ([431ef43](431ef43)) * **deps:** update dependency @testing-library/jest-dom to v5.14.0 ([fa0ab3b](fa0ab3b)) * **deps:** update dependency @testing-library/jest-dom to v5.14.1 ([ba97765](ba97765)) * **deps:** update dependency @testing-library/react to v11.2.7 ([40c056d](40c056d)) * **deps:** update dependency @testing-library/react to v12 ([#1639](#1639)) ([0436077](0436077)) * **deps:** update dependency @testing-library/user-event to v13.1.5 ([26abc52](26abc52)) * **deps:** update dependency @testing-library/user-event to v13.1.6 ([1785a5c](1785a5c)) * **deps:** update dependency @testing-library/user-event to v13.1.8 ([5b24c37](5b24c37)) * **deps:** update dependency @testing-library/user-event to v13.1.9 ([5bb281e](5bb281e)) * **deps:** update dependency @testing-library/user-event to v13.2.0 ([fca6234](fca6234)) * **deps:** update dependency @testing-library/user-event to v13.2.1 ([00ed45a](00ed45a)) * **deps:** update dependency @types/jest to v26.0.23 ([53485a4](53485a4)) * **deps:** update dependency @types/jest to v26.0.24 ([8b016e4](8b016e4)) * **deps:** update dependency @types/node to v14.14.42 ([4e951e3](4e951e3)) * **deps:** update dependency @types/node to v14.14.43 ([faa7d7f](faa7d7f)) * **deps:** update dependency @types/node to v14.14.44 ([e85da13](e85da13)) * **deps:** update dependency @types/node to v14.14.45 ([13d4006](13d4006)) * **deps:** update dependency @types/node to v14.17.0 ([85740b4](85740b4)) * **deps:** update dependency @types/node to v14.17.1 ([9ba5a5e](9ba5a5e)) * **deps:** update dependency @types/node to v14.17.2 ([3ed7dcd](3ed7dcd)) * **deps:** update dependency @types/node to v14.17.3 ([2b32d86](2b32d86)) * **deps:** update dependency @types/node to v14.17.4 ([db3c85c](db3c85c)) * **deps:** update dependency @types/node to v14.17.5 ([e58bcaa](e58bcaa)) * **deps:** update dependency @types/node to v14.17.6 ([7419e10](7419e10)) * **deps:** update dependency @types/node to v14.17.7 ([7dd68c4](7dd68c4)) * **deps:** update dependency @types/react to v17.0.10 ([24caf37](24caf37)) * **deps:** update dependency @types/react to v17.0.11 ([b57f5c9](b57f5c9)) * **deps:** update dependency @types/react to v17.0.13 ([9c2cb03](9c2cb03)) * **deps:** update dependency @types/react to v17.0.14 ([b2a2123](b2a2123)) * **deps:** update dependency @types/react to v17.0.15 ([748582d](748582d)) * **deps:** update dependency @types/react to v17.0.4 ([5bef9da](5bef9da)) * **deps:** update dependency @types/react to v17.0.5 ([686563d](686563d)) * **deps:** update dependency @types/react to v17.0.6 ([d8cd0d3](d8cd0d3)) * **deps:** update dependency @types/react to v17.0.7 ([684a46a](684a46a)) * **deps:** update dependency @types/react to v17.0.8 ([1c6e226](1c6e226)) * **deps:** update dependency @types/react to v17.0.9 ([2b4ff40](2b4ff40)) * **deps:** update dependency @types/react-dom to v17.0.4 ([0d86153](0d86153)) * **deps:** update dependency @types/react-dom to v17.0.5 ([d94534c](d94534c)) * **deps:** update dependency @types/react-dom to v17.0.6 ([ecae3cf](ecae3cf)) * **deps:** update dependency @types/react-dom to v17.0.7 ([4e73c47](4e73c47)) * **deps:** update dependency @types/react-dom to v17.0.8 ([716d424](716d424)) * **deps:** update dependency @types/react-dom to v17.0.9 ([3cd1fb0](3cd1fb0)) * **deps:** update dependency debug to v4.3.2 ([feabfef](feabfef)) * **deps:** update dependency electron-log to v4.3.5 ([e8e2b85](e8e2b85)) * **deps:** update dependency electron-log to v4.4.0 ([5e92358](5e92358)) * **deps:** update dependency electron-log to v4.4.1 ([477a011](477a011)) * **deps:** update dependency electron-updater to v4.3.10 ([c1ba768](c1ba768)) * **deps:** update dependency electron-updater to v4.3.9 ([3fe60d2](3fe60d2)) * **deps:** update dependency electron-updater to v4.4.0 ([1f2861d](1f2861d)) * **deps:** update dependency electron-updater to v4.4.1 ([c2bff6b](c2bff6b)) * **deps:** update dependency electron-updater to v4.4.2 ([c46a25b](c46a25b)) * **deps:** update dependency electron-updater to v4.4.3 ([811e9b8](811e9b8)) * **deps:** update dependency fs-extra to v10 ([#1509](#1509)) ([8621ded](8621ded)) * **deps:** update dependency i18next to v20.2.2 ([0e72a20](0e72a20)) * **deps:** update dependency i18next to v20.2.3 ([b1ed40d](b1ed40d)) * **deps:** update dependency i18next to v20.2.4 ([#1552](#1552)) ([01d8875](01d8875)) * **deps:** update dependency i18next to v20.3.0 ([70c0d9f](70c0d9f)) * **deps:** update dependency i18next to v20.3.1 ([dd442d1](dd442d1)) * **deps:** update dependency i18next to v20.3.2 ([e8ca39a](e8ca39a)) * **deps:** update dependency i18next to v20.3.3 ([5499723](5499723)) * **deps:** update dependency i18next to v20.3.4 ([fff9640](fff9640)) * **deps:** update dependency i18next to v20.3.5 ([9d88f16](9d88f16)) * **deps:** update dependency i18next-http-backend to v1.2.2 ([1c38a3b](1c38a3b)) * **deps:** update dependency i18next-http-backend to v1.2.4 ([0f4a748](0f4a748)) * **deps:** update dependency i18next-http-backend to v1.2.6 ([8b9186e](8b9186e)) * **deps:** update dependency i18next-http-backend to v1.2.7 ([8303dc8](8303dc8)) * **deps:** update dependency i18next-http-backend to v1.2.8 ([6079000](6079000)) * **deps:** update dependency i18next-http-backend to v1.3.0 ([38e43eb](38e43eb)) * **deps:** update dependency i18next-http-middleware to v3.1.2 ([741bab5](741bab5)) * **deps:** update dependency i18next-http-middleware to v3.1.3 ([9399bdf](9399bdf)) * **deps:** update dependency i18next-http-middleware to v3.1.4 ([81d1d18](81d1d18)) * **deps:** update dependency notistack to v1.0.10 ([#1725](#1725)) ([526377b](526377b)) * **deps:** update dependency notistack to v1.0.7 ([7326a28](7326a28)) * **deps:** update dependency notistack to v1.0.8 ([988844f](988844f)) * **deps:** update dependency notistack to v1.0.9 ([988c558](988c558)) * **deps:** update dependency object-hash to v2.2.0 ([568f6c9](568f6c9)) * **deps:** update dependency react-i18next to v11.10.0 ([08c50a1](08c50a1)) * **deps:** update dependency react-i18next to v11.11.0 ([1f27768](1f27768)) * **deps:** update dependency react-i18next to v11.11.1 ([4663ee2](4663ee2)) * **deps:** update dependency react-i18next to v11.11.2 ([15ab71c](15ab71c)) * **deps:** update dependency react-i18next to v11.11.3 ([9907f96](9907f96)) * **deps:** update dependency react-i18next to v11.11.4 ([#1726](#1726)) ([4467cdb](4467cdb)) * **deps:** update dependency react-i18next to v11.8.14 ([50c8841](50c8841)) * **deps:** update dependency react-i18next to v11.8.15 ([e6bcddd](e6bcddd)) * **deps:** update dependency react-i18next to v11.9.0 ([28b5fef](28b5fef)) * **deps:** update dependency react-redux to v7.2.4 ([d2b9328](d2b9328)) * **deps:** update dependency redux to v4.1.0 ([#1482](#1482)) ([9ccaf9c](9ccaf9c)) * **deps:** update dependency redux to v4.1.1 ([89b0dfd](89b0dfd)) * **deps:** update dependency typescript to v4.3.2 ([ff00be5](ff00be5)) * **deps:** update dependency typescript to v4.3.3 ([510e5eb](510e5eb)) * **deps:** update dependency typescript to v4.3.4 ([c37fd30](c37fd30)) * **deps:** update dependency typescript to v4.3.5 ([1d4aa51](1d4aa51)) * **deps:** update dependency web-vitals to v1.1.2 ([1819563](1819563)) * **deps:** update dependency web-vitals to v2 ([#1594](#1594)) ([c5721cb](c5721cb)) * **deps:** update dependency web-vitals to v2.1.0 ([7595f06](7595f06)) * **deps:** update sentry monorepo to v6.10.0 ([296155d](296155d)) * **deps:** update sentry monorepo to v6.3.0 ([d076bab](d076bab)) * **deps:** update sentry monorepo to v6.3.1 ([83d0ac6](83d0ac6)) * **deps:** update sentry monorepo to v6.3.3 ([e06d1b6](e06d1b6)) * **deps:** update sentry monorepo to v6.3.4 ([2e80b9b](2e80b9b)) * **deps:** update sentry monorepo to v6.3.5 ([2bdb1a9](2bdb1a9)) * **deps:** update sentry monorepo to v6.3.6 ([dd4efcd](dd4efcd)) * **deps:** update sentry monorepo to v6.4.0 ([#1556](#1556)) ([0ab3eaf](0ab3eaf)) * **deps:** update sentry monorepo to v6.4.1 ([2f464be](2f464be)) * **deps:** update sentry monorepo to v6.5.0 ([3a0a454](3a0a454)) * **deps:** update sentry monorepo to v6.5.1 ([ba804cf](ba804cf)) * **deps:** update sentry monorepo to v6.6.0 ([55b1f45](55b1f45)) * **deps:** update sentry monorepo to v6.7.0 ([b895474](b895474)) * **deps:** update sentry monorepo to v6.7.1 ([c9e7460](c9e7460)) * **deps:** update sentry monorepo to v6.7.2 ([ca48153](ca48153)) * **deps:** update sentry monorepo to v6.8.0 ([be43334](be43334)) * **deps:** update sentry monorepo to v6.9.0 ([b89da31](b89da31)) * **deps:** update socket.io packages to v4.0.2 ([46e95e3](46e95e3)) * **deps:** update socket.io packages to v4.1.0 ([9b64ba9](9b64ba9)) * **deps:** update socket.io packages to v4.1.1 ([39e635b](39e635b)) * **deps:** update socket.io packages to v4.1.2 ([f5daca0](f5daca0)) * **deps:** update socket.io packages to v4.1.3 ([face0fa](face0fa)) * **deps:** updated h5p dependencies ([fd8337a](fd8337a)) * **editor:** removed Lumi Run menu entry if not prerelease ([#1679](#1679)) ([476caa4](476caa4)) * **exports:** scorm export always works with interactive book ([#1715](#1715)) ([84ae568](84ae568)) * **i18n:** Translations update from Weblate ([#1553](#1553)) ([067ca11](067ca11)) * **i18n:** Translations update from Weblate ([#1566](#1566)) ([6065a85](6065a85)) * **locales:** updated Russian translation ([742de27](742de27)) * **menu:** added missing MacOS menu items and behaviour ([#1466](#1466)) ([4e72f06](4e72f06)) * **settings:** provide privacypolicy URL&change default settings for mas ([#1471](#1471)) ([c6de423](c6de423)) * **temp-storage:** move workingCache to temporary storage (fixes [#1136](#1136)) ([#1727](#1727)) ([274dd65](274dd65)) ### Features * **file:** add file association ([#1617](#1617)) ([ee5855d](ee5855d)) * **file-open:** open files in Lumi when clicked on (closes [#1169](#1169)) ([#1470](#1470)) ([121c190](121c190)) * **general:** only one instance of Lumi possible in all OSes ([#1652](#1652)) ([31b8dba](31b8dba)) * **prereleases:** allow prereleases to test future features ([#1548](#1548)) ([7210e62](7210e62)) * **run:** Add Lumi Run ([#1504](#1504)) ([e9fa47f](e9fa47f)) * **updates:** display update details and add update and restart button ([#1550](#1550)) ([6982907](6982907))

fix(temp-storage): move workingCache to temporary storage

8d9149d

JPSchellenberg added the [type] bug Something isn't working (resulting in patch-version) label Jul 27, 2021

fix(temp-storage): remove old workingCache directory on setup

d1f1a7b

JPSchellenberg marked this pull request as ready for review July 27, 2021 16:12

JPSchellenberg requested a review from sr258 July 27, 2021 16:12

sr258 requested changes Jul 27, 2021

View reviewed changes

JPSchellenberg added 4 commits July 27, 2021 22:27

fix(content-storage): rename workingCache to contentStorage

4a5d79f

fix(temp-storage): also remove deprecated tmp storage in userData

db59d39

test(lint): make linter happy

b18f6df

test(format): fix format

3c5268e

JPSchellenberg requested a review from sr258 July 27, 2021 20:49

refactor(setup): changed use of fs-extra

feb90bc

sr258 approved these changes Aug 2, 2021

View reviewed changes

sr258 merged commit 274dd65 into master Aug 2, 2021

github-actions bot added the released on @beta label Aug 4, 2021

sr258 deleted the fix/temporary-storage branch November 21, 2021 08:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(temp-storage): move workingCache to temporary storage (fixes #1136) #1727

fix(temp-storage): move workingCache to temporary storage (fixes #1136) #1727

JPSchellenberg commented Jul 27, 2021

JPSchellenberg commented Jul 27, 2021

sr258 left a comment •

edited

Loading

sr258 Jul 27, 2021

sr258 Jul 27, 2021

sr258 Jul 27, 2021

sr258 left a comment

github-actions bot commented Aug 4, 2021

fix(temp-storage): move workingCache to temporary storage (fixes #1136) #1727

fix(temp-storage): move workingCache to temporary storage (fixes #1136) #1727

Conversation

JPSchellenberg commented Jul 27, 2021

JPSchellenberg commented Jul 27, 2021

sr258 left a comment • edited Loading

Choose a reason for hiding this comment

sr258 Jul 27, 2021

Choose a reason for hiding this comment

sr258 Jul 27, 2021

Choose a reason for hiding this comment

sr258 Jul 27, 2021

Choose a reason for hiding this comment

sr258 left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 4, 2021

sr258 left a comment •

edited

Loading