bug fix for spark chart #483
Conversation
|
My review is in progress 📖 - I will have feedback for you in a few minutes! |
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I have reviewed your code and found 2 potential issues. To discuss my individual comments that I have added, tag me in replies using @korbit-ai.
Please react with a 👍 to my comments that you find helpful and a 👎 to those you find unhelpful - this will help me learn and improve as we collaborate.
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| setuptools.setup( | |||
| name="lumibot", | |||
| version="3.5.11", | |||
| version="3.5.12", | |||
There was a problem hiding this comment.
I noticed that the version of the library was updated in the 'setup.py' file, but there is no documentation explaining what changes were made in this version. It would be helpful to add a 'CHANGELOG.md' file to the repository or update it if it already exists. This file should contain a record of all changes made in each version of the library. For this specific pull request, a new entry should be added for version 3.5.12, explaining that a bug in the spark chart feature was fixed.
| @@ -3904,6 +3904,9 @@ def send_spark_chart_to_discord(self, stats_df, portfolio_value, now, days=180): | |||
| # Resanple the stats dataframe to daily but keep the datetime column | |||
| stats_df = stats_df.resample("D", on="datetime").last().reset_index() | |||
|
|
|||
| # Drop the cash column because it's not needed | |||
| stats_df = stats_df.drop(columns=["cash"]) | |||
There was a problem hiding this comment.
It seems that the 'cash' column is being dropped without checking if it exists in the dataframe. This could lead to a KeyError if the column is not present. To resolve this, you should check if the 'cash' column exists before attempting to drop it.
No description provided.