Polygon maxretry showpath #485
Conversation
|
My review is in progress 📖 - I will have feedback for you in a few minutes! |
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I have reviewed your code and found 2 potential issues. To discuss my individual comments that I have added, tag me in replies using @korbit-ai.
Please react with a 👍 to my comments that you find helpful and a 👎 to those you find unhelpful - this will help me learn and improve as we collaborate.
| message = ( | ||
| "Polygon rate limit reached.\n\n" | ||
| f"REST API call affected: {url}\n\n" | ||
| f"Sleeping for {PolygonClient.WAIT_SECONDS_RETRY} seconds seconds before trying again.\n\n" | ||
| "If you want to avoid this, consider a paid subscription with Polygon at https://polygon.io/?utm_source=affiliate&utm_campaign=lumi10\n" | ||
| "Please use the full link to give us credit for the sale, it helps support this project.\n" | ||
| "You can use the coupon code 'LUMI10' for 10% off." | ||
| ) |
There was a problem hiding this comment.
The log message in the MaxRetryError exception handling block is too verbose and contains sensitive information. Please simplify the log message and remove the coupon code from the log. Consider sending the coupon code to the user through a more secure channel.
| colored_message = colored( | ||
| f"Polygon rate limit reached. Sleeping for {PolygonClient.WAIT_SECONDS_RETRY} seconds before trying again. If you want to avoid this, consider a paid subscription with Polygon at https://polygon.io/?utm_source=affiliate&utm_campaign=lumi10 Please use the full link to give us credit for the sale, it helps support this project. You can use the coupon code 'LUMI10' for 10% off.", | ||
| "red", | ||
| url = urlunparse(urlparse(kwargs['path'])._replace(query="")) |
There was a problem hiding this comment.
The variable name 'url' in the MaxRetryError exception block is not descriptive enough to indicate its purpose. Consider renaming it to 'sanitized_url_path' to clarify that it represents the URL path without query parameters.
Better polygon message, showing REST API call path to better know which plan is needed.