Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulkaninfo: sleep(INFINITE) in vulkaninfo cause the tool to never complete when executed with vkconfig #1208

Open
KarenGhavam-lunarG opened this issue Oct 2, 2020 · 2 comments
Assignees
Labels

Comments

@KarenGhavam-lunarG
Copy link
Contributor

This issue was originally found during SDK 1.2.154.0 testing. It is being logged here for future fix.

  1. Selected my noAMDImplicit Layer configuration that has the AMD implicit layer disabled (we know this implicit layer interferes with vulkaninfo output):

image

The vulkaninfo output still seems incomplete. Attached file here.

vulkaninfoSDK.txt

From @christophe-lunarg

I have the same result on my machine.
Running with --json "workaround" the issue.

From @charles-lunarg

I have reproduced the issue, it is only happening when you launch vulkaninfo from vkconfig (by selecting the .exe manually and running it).
This happens when no overrides are enabled.

The issue doesn't occur when json or html is selected.
The issues is due to an unfortunate interaction with vulkaninfo and vkconfig, notably the fact that vulkaninfo tries to stay open indefinitely in the console, which vkconfig doesn't like.

Vulkaninfo Source code for reference:

if (ConsoleIsExclusive() && human_readable_output) Sleep(INFINITE); 

Note this only occurs with text output (human_readable).
Remove that line, and vulkaninfo prints the full output to vkconfig.

@christophe-lunarg christophe-lunarg changed the title vkconfig: vulkaninfo as defined app staying open indefinitely does not interact well with vkconfig vulkaninfo: as defined app staying open indefinitely does not interact well with vkconfig Oct 2, 2020
@christophe-lunarg
Copy link
Contributor

My recommendation would be to just remove that sleep(INFINITE) in vulkaninfo, command line tools should not be launched with the start menu.

@charles-lunarg
Copy link
Contributor

That would be a very big breaking change. And vulkaninfo isn't a command line app, it is an executable that people can open from the file explorer. On macOS, opening the vulkaninfo bundle creates terminal that lives for ever, just like windows.

The way I see it, vulkaninfo is thinking its running in its own console, when in reality its being run in a virtual console that vkconfig created. If we can update the logic of vulkaninfo to make sure it better understand the environment its running in and/or alter vkconfig to let the running apps know its inside another application, then it could be possible to sidestep the issue entirely (as the Sleep(INFINITE) only happens when vulkaninfo is running in an 'exclusive console').

@christophe-lunarg christophe-lunarg changed the title vulkaninfo: as defined app staying open indefinitely does not interact well with vkconfig vulkaninfo: sleep(INFINITE) in vulkaninfo cause the tool to never complete when executed with vkconfig Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants