Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api_dump get proc address should return success if driver returns success #808

Open
davidlunarg opened this issue Apr 26, 2019 · 1 comment
Labels
P3 Debt / Refactoring / Cosmetic Project - apidump apidump issues

Comments

@davidlunarg
Copy link
Contributor

ActionRPG on Android calls vkGetDeviceProcAddr for vkGetRefreshCycleDurationGOOGLE and vkGetPastPresentationTimingGOOGLE. Since these are instance functions, they fail.

The gfxreconstruct trace layer passes this call down to the next layer (the driver), which returns success, so the gfxreconstruct layer then returns the address of these functions in the gfxreconstruct layer.

The gfxreconstruct trace layer, strictly speaking, is not behaving correctly, but if the driver allows it, it allows it too, and the app works and can be traced. The api_dump layer (and other layers?) should do the same and not fail if the driver did not fail.

@KarenGhavam-lunarG KarenGhavam-lunarG added the Project - apidump apidump issues label Jul 3, 2019
@KarenGhavam-lunarG KarenGhavam-lunarG added P2 Has a workaround / Minor feature P3 Debt / Refactoring / Cosmetic and removed P2 Has a workaround / Minor feature labels Jul 23, 2019
@charles-lunarg
Copy link
Contributor

Both vkGetRefreshCycleDurationGOOGLE and vkGetPastPresentationTimingGOOGLE take a VkDevice as the first parameter. This really means they are device functions. Additionally, VK_GOOGLE_display_timing is listed as a device extension, so I'm not sure where the idea that these are instance functions came from.

Regardless, this seems like there is another issue at play that is the cause of crashes using these functions. Without more info it's hard to say what is amiss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Debt / Refactoring / Cosmetic Project - apidump apidump issues
Projects
None yet
Development

No branches or pull requests

3 participants