Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api_dump doesn't recognize special enums #955

Open
TonyBarbour opened this issue Jan 28, 2020 · 2 comments
Open

api_dump doesn't recognize special enums #955

TonyBarbour opened this issue Jan 28, 2020 · 2 comments
Assignees

Comments

@TonyBarbour
Copy link
Contributor

It would be nice if api_dump printed the enum for VK_QUEUE_FAMILY_IGNORED (for QueueFamilyIndex), VK_REMAINING_MIP_LEVELS (for levelCount), VK_REMAINING_ARRAY_LAYERS (for layerCount) and VK_WHOLE_SIZE for memory sizes and ranges. There are probably others.

@charles-lunarg
Copy link
Contributor

All of the listed constants are only references in the "API Constants" section of vk.xml, meaning none of the functions and parameters that could make use of it have a programmatic way to determine which constant is appropriate.
This wouldn't be difficult to hard code. A list of objects that name the constant, what types its used on, and the value. E.g {"type": "vkDeviceSize", "constant": "vk_whole_size" , "value": "~0ULL" }
I'm leery of hardcoding it though as it makes api_dump more brittle to future changes in the spec. It shouldn't be an issue anytime soon, but would need to be manually modified to take advantage of any new constants added.

@TonyBarbour
Copy link
Contributor Author

Add VK_ATTACHMENT_UNUSED to the list of enums that would be nice to see recognized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants