Change Some Warning/Error Messages to Debug Messages #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkY-LunarG
force-pushed
the
marky_master_fix_vulkaninfo_error
branch
2 times, most recently
from
5e77251
to
9207cb8
Compare
MarkY-LunarG
force-pushed
the
marky_master_fix_vulkaninfo_error
branch
from
9207cb8
to
7401c24
Compare
If both XCB and Wayland are present, the replay tool only uses one. This caused one of the Enum type queries to get a different count and return VK_INCOMPLETE. Now printing a debug message instead of a warning message for VK_INCOMPLETE, as the replay tool does not use the values returned by the query and the error should be safe to ignore.
Changing the log message type for a handle mapping failure from warning to debug.
dustin-lunarg
force-pushed
the
marky_master_fix_vulkaninfo_error
branch
from
7401c24
to
5d4d21f
Compare
dustin-lunarg
changed the title
|
I have modified this PR by altering the existing commit to change the log type from warning to debug, adding a new commit to change the handle mapping failure log type to debug, and to update the PR subject and summary to reflect the purpose for these changes. |
davidlunarg
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replay can produce VK_INCOMPLETE errors and handle mapping errors due to the issues described in #189 and #187. These errors do not impact replay and should be safe to ignore. Changing the type of log message used to report them to debug to reduce log noise, until the associated issues are fixed.