Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize Output Structure sType/pNext Fields for 'vkGet' Functions #196

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Initialize Output Structure sType/pNext Fields for 'vkGet' Functions #196

merged 1 commit into from
Feb 21, 2019

Conversation

dustin-lunarg
Copy link
Contributor

For 'vkGet' functions that fill one or more structures with data, replay was not initializing the sType of pNext members of the structures that were provided to these functions.

Fixes #159

@dustin-lunarg
Initialize sType/pNext for 'vkGet' functions
421fc03 
For 'vkGet' functions that fill one or more structures with data,
replay was not initializing the sType of pNext members of the
structures that were provided to these functions.
@dustin-lunarg dustin-lunarg mentioned this pull request Feb 20, 2019
Closed
lunarpapillo
lunarpapillo reviewed Feb 20, 2019
View reviewed changes
Copy link
Contributor

@lunarpapillo lunarpapillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some questions I'd like someone to double-check and verify, but otherwise these changes look good to me. I'll test them momentarily and approve after testing.

lunarpapillo
lunarpapillo approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@lunarpapillo lunarpapillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested dustin_fix_pnext_output with a vulkaninfo trace and it executes fine, without a segfault.

@dustin-lunarg dustin-lunarg merged commit a7ddaf4 into master Feb 21, 2019
@dustin-lunarg dustin-lunarg deleted the dustin_fix_pnext_output branch February 21, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunarpapillo lunarpapillo lunarpapillo approved these changes

@davidlunarg davidlunarg davidlunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dustin-lunarg @davidlunarg @lunarpapillo